Update Code to 1.84.0 #6517
Closed
Update Code to 1.84.0 #6517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functionality [modified by patches] tested and found to work:
Jupyter Notebooks also work fine: |
|
Ping @code-asher. Please review and let the checks run. |
|
@code-asher I can confirm both #6500 and #3061. On my test (https://coder.jupyter.b-data.ch/) and demo (https://demo.jupyter.b-data.ch/) deployment I could work around this issue by reloading the webpage a few times. P.S.: I do not use Worksapces myself. Only managing projects using the 'Project Manager' extension. |
|
Ping @code-asher Please let the checks run. |
|
Closed in favour of #6519. |
benz0li
referenced
this pull request
Nov 21, 2023
The main goal of this patch was to make user settings stored on disk instead of in the browser, but this stopped working some time ago. Not only that but it is causing a bug where a workspace will not fully open. A secondary goal was to fix the Vim extension but the extension appears to work just fine without this change now (both the server and browser versions). This patch is not useful anymore anyway because there are remote-level settings that *do* get stored on disk and can be used instead of user-level settings when necessary. Fixes #3061, and possibly #6153.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6516